Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.x] Date-specific enums and constants #53983

Closed
wants to merge 18 commits into from

Conversation

shaedrich
Copy link
Contributor

See #53961 and #53976

@shaedrich shaedrich mentioned this pull request Dec 19, 2024
@shaedrich shaedrich changed the title Date-specific enums and constants [11.x] Date-specific enums and constants Dec 19, 2024
@taylorotwell
Copy link
Member

Thanks for your pull request to Laravel!

Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.

If applicable, please consider releasing your code as a package so that the community can still take advantage of your contributions!

@shaedrich
Copy link
Contributor Author

This stuff doesn't really need to go to master.
— Taylor Otwell

master's my better safe than sorry here 😅
@shaedrich

If you want to separately PR a simple Day enum go for it. I don't see why it couldn't go to 11.x.
— Taylor Otwell

Can't say, I'm surprised …

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants